Remove cleanup from startup #2241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

openshift-merge-robot merged 1 commit into operator-framework:master from ecordell:rm-cleanup

Jul 8, 2021

Member

ecordell commented Jul 7, 2021

Description of the change:
Remove cleanup from startup

Motivation for the change:
a series of cleanup steps run on start, but they are only required
when updating from very old versions of olm. it doesn't make sense to
carry them forever.

Reviewer Checklist

Implementation matches the proposed design, or proposal is updated to match implementation
Sufficient unit test coverage
Sufficient end-to-end test coverage
Docs updated or added to /doc
Commit messages sensible and descriptive


          remove cleanup from startup

fc28c1f

a series of cleanup steps run on start, but they are only required
when updating from very old versions of olm. it doesn't make sense to
carry them forever.

openshift-ci bot requested review from anik120 and awgreene

July 7, 2021 21:50

openshift-ci bot added the approved label

njhale approved these changes

View reviewed changes

Member

njhale left a comment

This seems fine. The versions of OLM that the cleanup addresses are obsolete.

Users can step through an intermediate version if they want a seamless upgrade anyway.

/lgtm

openshift-ci bot assigned njhale

openshift-ci bot added the lgtm label

openshift-ci bot commented Jul 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ecordell,njhale]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Member Author

ecordell commented Jul 7, 2021

/hold

want to double check that we don't need 05f5417#diff-4ce7e916862e18b439f8ce8edbf0b0a85f384589f0ef2b8c5ff32237cb907da9

openshift-ci bot added the do-not-merge/hold label

Member Author

ecordell commented Jul 7, 2021

/hold cancel

that one looks fine - hasn't been needed since ocp 4.4

openshift-ci bot removed the do-not-merge/hold label

Member

timflannagan commented Jul 7, 2021

/rerun-all

Contributor

openshift-bot commented Jul 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments

Contributor

openshift-bot commented Jul 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Member

timflannagan commented Jul 8, 2021

Need to investigate why that e2e-tests action is continuously timing out so the openshift-bot doesn't perma-retest.

/hold

openshift-ci bot added the do-not-merge/hold label

Member Author

ecordell commented Jul 8, 2021

/hold cancel

openshift-ci bot removed the do-not-merge/hold label

openshift-merge-robot merged commit e20f43d into operator-framework:master

Member

kevinrizza commented Jul 14, 2021

/cherry-pick release-4.7

openshift-cherrypick-robot mentioned this pull request

[release-4.7] Bug 1982693: Remove cleanup from startup #2257

Closed

openshift-cherrypick-robot commented Jul 14, 2021

@kevinrizza: new pull request created: #2257

In response to this:

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Member

kevinrizza commented Jul 26, 2021

/cherry-pick release-4.6

openshift-cherrypick-robot mentioned this pull request

[release-4.6] Remove cleanup from startup #2289

Closed

openshift-cherrypick-robot commented Jul 26, 2021

@kevinrizza: new pull request created: #2289

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels