-
Notifications
You must be signed in to change notification settings - Fork 562
feat(resolver): Indicate dependency class in resolution constraint text #2258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(resolver): Indicate dependency class in resolution constraint text #2258
Conversation
Signed-off-by: Anik Bhattacharjee <[email protected]>
a6f183f
to
c571eb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
c571eb3
to
1e78d44
Compare
1e78d44
to
2f5fc18
Compare
This commit introduces a String() method to the Predicate interface, implementations of which are used to build clauses that are fed to the sat solver. Calling the predicate.String() method enhances the error messages displayed when dependency resolution fails. For example, an error message previously due to an unsatisfyiable contraint was diplayed as ``` ResolutionFailed' constraints not satisfiable: bundle etcdoperator-community.v0.6.1 has a dependency without any candidates to satisfy it, subscription etcd requires my-catalog/olm/alpha/etcdoperator-community.v0.6.1, subscription etcd exists ``` With this commit, the same error is displayed as: ``` ResolutionFailed' constraints not satisfiable: bundle etcdoperator-community.v0.6.1 requires an operator with package:foo and with version in range:>0.27.0, subscription etcd requires my-catalog/olm/alpha/etcdoperator-community.v0.6.1, subscription etcd exists ``` Signed-off-by: Anik Bhattacharjee <[email protected]>
2f5fc18
to
8c0f4aa
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anik120, ankitathomas, benluddy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of the change:
This PRintroduces a
String()
method to the Predicate interface, implementationsof which are used to build clauses that are fed to the sat solver. Calling the
predicate.String() method enhances the error messages displayed when dependency
resolution fails.
For example, an error message previously due to an unsatisfyiable contraint was
diplayed as
With this commit, the same error is displayed as:
Motivation for the change:
Reviewer Checklist
/doc