[release-4.7] Bug 1982693: remove cleanup from startup #2287

dinhxuanvu · 2021-07-23T19:12:06Z

a series of cleanup steps run on start, but they are only required
when updating from very old versions of olm. it doesn't make sense to
carry them forever.

Description of the change:

Motivation for the change:

Reviewer Checklist

Implementation matches the proposed design, or proposal is updated to match implementation
Sufficient unit test coverage
Sufficient end-to-end test coverage
Docs updated or added to /doc
Commit messages sensible and descriptive

a series of cleanup steps run on start, but they are only required when updating from very old versions of olm. it doesn't make sense to carry them forever.

openshift-ci · 2021-07-23T19:12:07Z

@dinhxuanvu: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[WIP] remove cleanup from startup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

The current kind (0.7.0) is too old and using k8s 1.17. Update the kind package to 0.11.1 to utilize newer version of k8s. Signed-off-by: Vu Dinh <[email protected]>

openshift-ci · 2021-07-23T21:08:55Z

@dinhxuanvu: This pull request references Bugzilla bug 1982693, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.z) matches configured target release for branch (4.7.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1982252 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1982252 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0, 4.8.z
bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

[release-4.7] Bug 1982693: remove cleanup from startup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-07-23T21:08:56Z

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: jianzhangbjz.

Note that only operator-framework members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@dinhxuanvu: This pull request references Bugzilla bug 1982693, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)

bug target release (4.7.z) matches configured target release for branch (4.7.z)

bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

dependent bug Bugzilla bug 1982252 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))

dependent Bugzilla bug 1982252 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0, 4.8.z

bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

[release-4.7] Bug 1982693: remove cleanup from startup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kevinrizza · 2021-07-23T21:10:13Z

/lgtm
/approve

openshift-ci · 2021-07-23T21:10:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kevinrizza]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-07-23T22:38:25Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-23T22:50:25Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-24T00:02:27Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-24T00:14:26Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-07-24T02:47:01Z

@dinhxuanvu: All pull requests linked via external trackers have merged:

operator-framework/operator-lifecycle-manager#2287

Bugzilla bug 1982693 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 1982693: remove cleanup from startup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kevinrizza · 2021-07-26T14:54:35Z

/cherry-pick release-4.6

openshift-cherrypick-robot · 2021-07-26T14:55:19Z

@kevinrizza: #2287 failed to apply on top of branch "release-4.6":

Applying: remove cleanup from startup
Applying: Update kind package to 0.11.1
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
A	vendor/golang.org/x/sys/unix/asm_openbsd_mips64.s
M	vendor/golang.org/x/sys/unix/mkerrors.sh
M	vendor/golang.org/x/sys/unix/syscall_darwin.go
M	vendor/golang.org/x/sys/unix/syscall_darwin_386.go
M	vendor/golang.org/x/sys/unix/syscall_darwin_amd64.go
M	vendor/golang.org/x/sys/unix/syscall_darwin_arm.go
M	vendor/golang.org/x/sys/unix/syscall_darwin_arm64.go
M	vendor/golang.org/x/sys/unix/syscall_dragonfly.go
M	vendor/golang.org/x/sys/unix/syscall_illumos.go
M	vendor/golang.org/x/sys/unix/syscall_linux.go
A	vendor/golang.org/x/sys/unix/syscall_linux_gc_arm.go
M	vendor/golang.org/x/sys/unix/syscall_solaris.go
M	vendor/golang.org/x/sys/unix/zerrors_linux.go
M	vendor/golang.org/x/sys/unix/zerrors_linux_386.go
M	vendor/golang.org/x/sys/unix/zerrors_linux_amd64.go
M	vendor/golang.org/x/sys/unix/zerrors_linux_arm.go
M	vendor/golang.org/x/sys/unix/zerrors_linux_arm64.go
M	vendor/golang.org/x/sys/unix/zerrors_linux_mips.go
M	vendor/golang.org/x/sys/unix/zerrors_linux_mips64.go
M	vendor/golang.org/x/sys/unix/zerrors_linux_mips64le.go
M	vendor/golang.org/x/sys/unix/zerrors_linux_mipsle.go
M	vendor/golang.org/x/sys/unix/zerrors_linux_ppc64.go
M	vendor/golang.org/x/sys/unix/zerrors_linux_ppc64le.go
M	vendor/golang.org/x/sys/unix/zerrors_linux_riscv64.go
M	vendor/golang.org/x/sys/unix/zerrors_linux_s390x.go
M	vendor/golang.org/x/sys/unix/zerrors_linux_sparc64.go
M	vendor/golang.org/x/sys/unix/zsyscall_darwin_386.go
M	vendor/golang.org/x/sys/unix/zsyscall_darwin_amd64.go
M	vendor/golang.org/x/sys/unix/zsyscall_darwin_arm.go
M	vendor/golang.org/x/sys/unix/zsyscall_darwin_arm64.go
M	vendor/golang.org/x/sys/unix/zsyscall_dragonfly_amd64.go
M	vendor/golang.org/x/sys/unix/zsyscall_illumos_amd64.go
M	vendor/golang.org/x/sys/unix/zsysnum_linux_386.go
M	vendor/golang.org/x/sys/unix/zsysnum_linux_amd64.go
M	vendor/golang.org/x/sys/unix/zsysnum_linux_arm.go
M	vendor/golang.org/x/sys/unix/zsysnum_linux_arm64.go
M	vendor/golang.org/x/sys/unix/zsysnum_linux_mips.go
M	vendor/golang.org/x/sys/unix/zsysnum_linux_mips64.go
M	vendor/golang.org/x/sys/unix/zsysnum_linux_mips64le.go
M	vendor/golang.org/x/sys/unix/zsysnum_linux_mipsle.go
M	vendor/golang.org/x/sys/unix/zsysnum_linux_ppc64.go
M	vendor/golang.org/x/sys/unix/zsysnum_linux_ppc64le.go
M	vendor/golang.org/x/sys/unix/zsysnum_linux_riscv64.go
M	vendor/golang.org/x/sys/unix/zsysnum_linux_s390x.go
M	vendor/golang.org/x/sys/unix/zsysnum_linux_sparc64.go
M	vendor/golang.org/x/sys/unix/ztypes_darwin_386.go
M	vendor/golang.org/x/sys/unix/ztypes_darwin_amd64.go
M	vendor/golang.org/x/sys/unix/ztypes_darwin_arm.go
M	vendor/golang.org/x/sys/unix/ztypes_darwin_arm64.go
M	vendor/golang.org/x/sys/unix/ztypes_dragonfly_amd64.go
M	vendor/golang.org/x/sys/unix/ztypes_linux.go
M	vendor/golang.org/x/sys/unix/ztypes_linux_386.go
M	vendor/golang.org/x/sys/unix/ztypes_linux_amd64.go
M	vendor/golang.org/x/sys/unix/ztypes_linux_arm.go
M	vendor/golang.org/x/sys/unix/ztypes_linux_arm64.go
M	vendor/golang.org/x/sys/unix/ztypes_linux_mips.go
M	vendor/golang.org/x/sys/unix/ztypes_linux_mips64.go
M	vendor/golang.org/x/sys/unix/ztypes_linux_mips64le.go.git/rebase-apply/patch:821: trailing whitespace.
Redistribution and use in source and binary forms, with or without 
.git/rebase-apply/patch:829: trailing whitespace.
* Neither the name of the Evan Phoenix nor the names of its contributors 
.git/rebase-apply/patch:830: trailing whitespace.
  may be used to endorse or promote products derived from this software 
.git/rebase-apply/patch:833: trailing whitespace.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" 
.git/rebase-apply/patch:834: trailing whitespace.
AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 
error: patch failed: vendor/github.com/pelletier/go-toml/example-crlf.toml:27
error: vendor/github.com/pelletier/go-toml/example-crlf.toml: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch=diff' to see the failed patch

M	vendor/golang.org/x/sys/unix/ztypes_linux_mipsle.go
M	vendor/golang.org/x/sys/unix/ztypes_linux_ppc64.go
M	vendor/golang.org/x/sys/unix/ztypes_linux_ppc64le.go
M	vendor/golang.org/x/sys/unix/ztypes_linux_riscv64.go
M	vendor/golang.org/x/sys/unix/ztypes_linux_s390x.go
M	vendor/golang.org/x/sys/unix/ztypes_linux_sparc64.go
A	vendor/golang.org/x/sys/unix/ztypes_openbsd_mips64.go
M	vendor/golang.org/x/sys/unix/ztypes_solaris_amd64.go
M	vendor/golang.org/x/sys/windows/service.go
M	vendor/golang.org/x/sys/windows/syscall_windows.go
M	vendor/golang.org/x/sys/windows/types_windows.go
M	vendor/golang.org/x/sys/windows/zsyscall_windows.go
M	vendor/gopkg.in/yaml.v3/yaml.go
M	vendor/modules.txt
Patch failed at 0002 Update kind package to 0.11.1
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

remove cleanup from startup

48c719d

a series of cleanup steps run on start, but they are only required when updating from very old versions of olm. it doesn't make sense to carry them forever.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 23, 2021

openshift-ci bot requested review from anik120 and joelanford July 23, 2021 19:12

dinhxuanvu force-pushed the test-4.7 branch from d5492a5 to b797a9f Compare July 23, 2021 20:49

Update kind package to 0.11.1

0f31a6e

The current kind (0.7.0) is too old and using k8s 1.17. Update the kind package to 0.11.1 to utilize newer version of k8s. Signed-off-by: Vu Dinh <[email protected]>

dinhxuanvu force-pushed the test-4.7 branch from b797a9f to 0f31a6e Compare July 23, 2021 21:05

dinhxuanvu mentioned this pull request Jul 23, 2021

[release-4.7] Bug 1982693: Remove cleanup from startup #2257

Closed

dinhxuanvu changed the title ~~[WIP] remove cleanup from startup~~ [release-4.7] Bug 1982693: remove cleanup from startup Jul 23, 2021

openshift-ci bot assigned kevinrizza Jul 23, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2021

mrunalp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 23, 2021

openshift-merge-robot merged commit dcbab9a into operator-framework:release-4.7 Jul 24, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[release-4.7] Bug 1982693: remove cleanup from startup #2287

[release-4.7] Bug 1982693: remove cleanup from startup #2287

Uh oh!

dinhxuanvu commented Jul 23, 2021

Uh oh!

openshift-ci bot commented Jul 23, 2021

Uh oh!

openshift-ci bot commented Jul 23, 2021

Uh oh!

openshift-ci bot commented Jul 23, 2021

Uh oh!

kevinrizza commented Jul 23, 2021

Uh oh!

openshift-ci bot commented Jul 23, 2021

Uh oh!

openshift-bot commented Jul 23, 2021

Uh oh!

openshift-bot commented Jul 23, 2021

Uh oh!

openshift-bot commented Jul 24, 2021

Uh oh!

openshift-bot commented Jul 24, 2021

Uh oh!

openshift-ci bot commented Jul 24, 2021

Uh oh!

kevinrizza commented Jul 26, 2021

Uh oh!

openshift-cherrypick-robot commented Jul 26, 2021

Uh oh!

Uh oh!

[release-4.7] Bug 1982693: remove cleanup from startup #2287

[release-4.7] Bug 1982693: remove cleanup from startup #2287

Uh oh!

Conversation

dinhxuanvu commented Jul 23, 2021

Uh oh!

openshift-ci bot commented Jul 23, 2021

Uh oh!

openshift-ci bot commented Jul 23, 2021

Uh oh!

openshift-ci bot commented Jul 23, 2021

Uh oh!

kevinrizza commented Jul 23, 2021

Uh oh!

openshift-ci bot commented Jul 23, 2021

Uh oh!

openshift-bot commented Jul 23, 2021

Uh oh!

openshift-bot commented Jul 23, 2021

Uh oh!

openshift-bot commented Jul 24, 2021

Uh oh!

openshift-bot commented Jul 24, 2021

Uh oh!

openshift-ci bot commented Jul 24, 2021

Uh oh!

kevinrizza commented Jul 26, 2021

Uh oh!

openshift-cherrypick-robot commented Jul 26, 2021

Uh oh!

Uh oh!