Skip to content

.github/workflows: Bump the docker/build-push-action to the v2 version #2300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

timflannagan
Copy link
Member

Update the test-scripts.yml workflow and replace the
docker/build-push-action to use the v2 version.

These changes were made by following their upgrade from v1 to v2 guide:

We only use this action currently to ensure that builds are successful
and don't push (or test against) the newly build container image.

Fixes #2144

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive

@openshift-ci openshift-ci bot requested review from exdx and kevinrizza July 28, 2021 20:44
@timflannagan timflannagan force-pushed the bump-docker-build-action-version branch from 64986a7 to 296c9da Compare July 28, 2021 20:44
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2021
@timflannagan timflannagan force-pushed the bump-docker-build-action-version branch from 296c9da to c3bda93 Compare September 10, 2021 18:43
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 10, 2021
@timflannagan timflannagan force-pushed the bump-docker-build-action-version branch from c3bda93 to 8563f6f Compare September 10, 2021 18:43
@joelanford
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2021
@kevinrizza
Copy link
Member

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevinrizza, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2021
@timflannagan
Copy link
Member Author

/override unit

@openshift-ci
Copy link

openshift-ci bot commented Sep 14, 2021

@timflannagan: /override requires a failed status context or a job name to operate on.
The following unknown contexts were given:

  • unit

Only the following contexts were expected:

  • tide

In response to this:

/override unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timflannagan
Copy link
Member Author

Manually merging - that unit test is permafailing.

@timflannagan
Copy link
Member Author

#2091

@timflannagan timflannagan merged commit 11f1d0c into operator-framework:master Sep 14, 2021
@timflannagan timflannagan deleted the bump-docker-build-action-version branch September 14, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The image-build GH action job uses a deprecated docker/build-push-action version
3 participants