cmd/catalog: Default to the $KUBECONFIG environment variable when building client configs #2303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timflannagan
commented
Jul 29, 2021
| @@ -37,7 +37,7 @@ const ( | |||
| // config flags defined globally so that they appear on the test binary as well | |||
| var ( | |||
| kubeConfigPath = flag.String( | |||
| "kubeconfig", "", "absolute path to the kubeconfig file") | |||
| "kubeconfig", os.Getenv("KUBECONFIG"), "absolute path to the kubeconfig file") | |||
There was a problem hiding this comment.
When providing the value through the CLI flag, that value still takes precedence over the local $KUBECONFIG environment variable, which seems like the correct behavior. Might be worth calling out that behavior in this flags description?
timflannagan
force-pushed
the
update-catalog-operator-kubeconfig-flag-handling
branch
2 times, most recently
from
1174dcf to
f0f5219
Compare
timflannagan
force-pushed
the
update-catalog-operator-kubeconfig-flag-handling
branch
from
f0f5219 to
f1b10a7
Compare
timflannagan
force-pushed
the
update-catalog-operator-kubeconfig-flag-handling
branch
from
f1b10a7 to
1c863c5
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Update the catalog operator and default to the $KUBECONFIG environment variable value when the --kubeconfig flag hasn't been provided. This mirrors the same way that the olm operator (e.g. controller-runtime is handling this check under-the-hood) behaves. Signed-off-by: timflannagan <[email protected]>
timflannagan
force-pushed
the
update-catalog-operator-kubeconfig-flag-handling
branch
from
1c863c5 to
9ff3357
Compare
|
/lgtm |
timflannagan
deleted the
update-catalog-operator-kubeconfig-flag-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the catalog operator and default to the $KUBECONFIG environment
variable value when the --kubeconfig flag hasn't been provided. This
mirrors the same way that the olm operator (e.g. controller-runtime is
handling this check under-the-hood) behaves.
Description of the change:
Motivation for the change:
Reviewer Checklist
/doc