Skip to content

Makefile,test: Remove the test/rh-operators directory #2354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

timflannagan
Copy link
Member

Description of the change:
Update the root Makefile and remove the target for running the metric
e2e tests.

Remove the test/rh-operators directory.

Motivation for the change:
Lowers maintenance burden by removing tests that add little value and helps decouple upstream OLM from housing OCP-specific content.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive

Update the root Makefile and remove the target for running the metric
e2e tests.

Remove the test/rh-operators directory.

Signed-off-by: timflannagan <[email protected]>
@timflannagan
Copy link
Member Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2021
@openshift-ci openshift-ci bot requested review from ecordell and hasbro17 September 14, 2021 17:23
@timflannagan
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2021
@timflannagan
Copy link
Member Author

/re-run all

Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2021
@estroz
Copy link
Member

estroz commented Sep 17, 2021

/rerun-all

@estroz
Copy link
Member

estroz commented Sep 17, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2021
@timflannagan
Copy link
Member Author

/rerun-all

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@timflannagan
Copy link
Member Author

Manually merging as the labels as present and these changes don't influence e2e failures.

@timflannagan timflannagan merged commit 45b334b into operator-framework:master Sep 20, 2021
@timflannagan timflannagan deleted the remove-rh-operators-test-packages branch September 20, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants