Skip to content

Makefile: Reduce flake attempts when running the e2e suite in CI #2402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Makefile: Reduce flake attempts when running the e2e suite in CI #2402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ setup-bare: clean e2e.namespace
. ./scripts/package_release.sh 1.0.0 test/e2e/resources test/e2e/e2e-bare-values.yaml
. ./scripts/install_bare.sh $(shell cat ./e2e.namespace) test/e2e/resources

GINKGO_OPTS := -flakeAttempts 3 -randomizeAllSpecs -v --timeout 120m
GINKGO_OPTS := -flakeAttempts 1 -randomizeAllSpecs -v --timeout 120m

# TODO(tflannag): Remove this target entirely and move downstream
e2e:
Expand All @@ -139,9 +139,14 @@ e2e:
FORCE:

# main entry point for running end to end tests. used by .github/workflows/e2e-tests.yml See test/e2e/README.md for details
# TODO(tflannag): Temporarily decrement flake attempts to 1 to weed out any flakes
# or problematic tests that are masked by the flake attempts. Determine an appropriate
# value long term that balances out flake tolerance with contributor experience.
# See https://github.com/operator-framework/operator-lifecycle-manager/issues/2401 for more
# information.
.PHONY: e2e-local
e2e-local: bin/e2e-local.test test/e2e-local.image.tar
$(GINKGO) -nodes $(or $(NODES),1) -flakeAttempts 3 -randomizeAllSpecs $(if $(TEST),-focus '$(TEST)') -v -timeout 90m $< -- -namespace=operators -olmNamespace=operator-lifecycle-manager -dummyImage=bitnami/nginx:latest -kind.images=../test/e2e-local.image.tar
$(GINKGO) -nodes $(or $(NODES),1) -flakeAttempts 1 -randomizeAllSpecs $(if $(TEST),-focus '$(TEST)') -v -timeout 90m $< -- -namespace=operators -olmNamespace=operator-lifecycle-manager -dummyImage=bitnami/nginx:latest -kind.images=../test/e2e-local.image.tar

# this target updates the zz_chart.go file with files found in deploy/chart
# this will always fire since it has been marked as phony
Expand Down