[release-4.7] Bug 1986932: resolver: remove legacy support for fallback parsing of CSVs #2404
Conversation
openshift-ci
bot
added
bugzilla/severity-medium
|
@timflannagan: This pull request references Bugzilla bug 1986932, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Welp I read that BZ wrong. /hold |
openshift-ci
bot
added
the
do-not-merge/hold
timflannagan
changed the title
|
/bugzilla refresh |
|
@timflannagan: This pull request references Bugzilla bug 1986932, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/valid-bug
|
@timflannagan: This pull request references Bugzilla bug 1986932, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: jianzhangbjz. Note that only operator-framework members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When no APIs or properties are present on bundles, the resolver currently falls back to a legacy mode where that information is parsed from CSVs present in the index. This legacy fallback method causes the resolver to incorrectly identify multiple heads for a channel when: a) The index contains CSVs only on channel head bundles, and b) A package contains two channels, where one channel contains the head of the other channel and there is at least one other node between these channel head nodes in that channel. c) The bundles have no properties, provided APIs, or required APIs Conditions a) and b) are extremely prevalent, so this bug will often be encountered whenever c) itself is true. This commit removes support for the legacy CSV parsing fallback, which means that only first class fields in the GRPC API will be used during resolutions. Signed-off-by: Joe Lanford <[email protected]>
timflannagan
force-pushed
the
release-4.7-bz-1986932
branch
from
5b7dfbb to
15d0ab0
Compare
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
openshift-ci
bot
added
the
approved
|
/retest |
|
Hmm, going to retest that e2e-aws-console-olm test, but that test may be broken: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, njhale, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/backport-risk-assessed |
|
/label backport-risk-assessed |
openshift-ci
bot
added
the
backport-risk-assessed
mrunalp
added
the
cherry-pick-approved
|
@timflannagan: All pull requests linked via external trackers have merged: Bugzilla bug 1986932 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When no APIs or properties are present on bundles, the resolver
currently falls back to a legacy mode where that information is parsed
from CSVs present in the index.
This legacy fallback method causes the resolver to incorrectly identify
multiple heads for a channel when:
a) The index contains CSVs only on channel head bundles, and
b) A package contains two channels, where one channel contains the head
of the other channel and there is at least one other node between
these channel head nodes in that channel.
c) The bundles have no properties, provided APIs, or required APIs
Conditions a) and b) are extremely prevalent, so this bug will often be
encountered whenever c) itself is true.
This commit removes support for the legacy CSV parsing fallback, which
means that only first class fields in the GRPC API will be used during
resolutions.
Signed-off-by: Joe Lanford [email protected]
Description of the change:
Motivation for the change:
Reviewer Checklist
/doc