.github/workflows: Avoid specifying the paths-ignore keyword #2511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the CI-related workflows and avoid specifying the paths-ignore keyword. Because we have configure required status contexts through branch protection rules, any workflow that is skipped due to path filtering results in an unknown status, which results in tide stalling any merge despite a PR matching the merge criteria (e.g. lgtm/approval label present). This is a short term fix to the solution: the long term solution is dynamically filtering out certain file paths as a pre-requisite job vs. statically filtering using the paths-ignore filter, while we wait for GitHub to add this as first-class functionality. Signed-off-by: timflannagan <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, perdasilva, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the CI-related workflows and avoid specifying the paths-ignore
keyword. Because we have configure required status contexts through
branch protection rules, any workflow that is skipped due to path
filtering results in an unknown status, which results in tide stalling
any merge despite a PR matching the merge criteria (e.g. lgtm/approval
label present).
This is a short term fix to the solution: the long term
solution is dynamically filtering out certain file paths as a
pre-requisite job vs. statically filtering using the paths-ignore
filter, while we wait for GitHub to add this as first-class functionality.
Signed-off-by: timflannagan [email protected]
Description of the change:
Motivation for the change:
Reviewer Checklist
/doc