-
Notifications
You must be signed in to change notification settings - Fork 562
WIP: Introduce olm config (Revert CR Bump in API Repo) #2513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Introduce olm config (Revert CR Bump in API Repo) #2513
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -62,6 +62,7 @@ replace ( | |||
// controller runtime | |||
github.com/openshift/api => github.com/openshift/api v0.0.0-20200331152225-585af27e34fd // release-4.5 | |||
github.com/openshift/client-go => github.com/openshift/client-go v0.0.0-20200326155132-2a6cd50aedd0 // release-4.5 | |||
github.com/operator-framework/api => github.com/awgreene/api v0.0.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: If we are not able to unblock #2368 then revert the CR bump in operator-framework/api#154
apiVersion: operators.coreos.com/v1 | ||
kind: OLMConfig | ||
metadata: | ||
name: cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure this needs to be included by default; OLM should probably create a default if it can't find one on the cluster.
nit: we need to make sure this isn't included downstream by default b/c CVO will stomp user changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd need to add the create-only annotation downstream.
Closing in favor of #2466 |
This PR is similar to #2466 but revert the CR bump in the api repo.