chore(constraint): Correct message to failureMessage in olm.constraint schema #2572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@dinhxuanvu Can you rebase when you get a chance? I can tag once that's done and the checks are passing (just to avoid the openshift-bot retest spam). |
| @@ -24,7 +24,7 @@ require ( | |||
| github.com/onsi/gomega v1.15.0 | |||
| github.com/openshift/api v0.0.0-20200331152225-585af27e34fd | |||
| github.com/openshift/client-go v0.0.0-20200326155132-2a6cd50aedd0 | |||
| github.com/operator-framework/api v0.11.0 | |||
| github.com/operator-framework/api v0.11.1 | |||
There was a problem hiding this comment.
Just for other reviewers: operator-framework/api@1602407 is tagged v0.11.1 on the o-f/api side.
…t schema The correct field for olm.constraint is `failureMessage` instead of `message` as it is currently in the code. This change is to honor the field name that is specified in the original enhancement. Signed-off-by: Vu Dinh <[email protected]>
dinhxuanvu
force-pushed
the
failure-msg
branch
from
5cc09ed to
b27b914
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The correct field for olm.constraint is
failureMessageinstead ofmessageas it is currently in the code. This change is to honor the field name that
is specified in the original enhancement.
Signed-off-by: Vu Dinh [email protected]
Description of the change:
Motivation for the change:
Reviewer Checklist
/doc