count only active ns #2585
Merged
count only active ns #2585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akihikokuroda
force-pushed
the
activens
branch
2 times, most recently
from
9dca592 to
908efc4
Compare
akihikokuroda
force-pushed
the
activens
branch
2 times, most recently
from
b8808c3 to
d513026
Compare
|
@awgreene can you take a look at these changes when you get a chance? I think this is ready to go when it passes e2e. |
|
@akihikokuroda Can you rebase this when you get a chance? |
Signed-off-by: akihikokuroda <[email protected]>
akihikokuroda
force-pushed
the
activens
branch
from
d513026 to
0af544a
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akihikokuroda, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: akihikokuroda [email protected]
Description of the change:
The csv is copied only to the active namespaces. The test counts all namespaces for comparison including terminating namespaces. This change counts only active namespaces.
Motivation for the change:
Closes #2583
Reviewer Checklist
/doc