wait for operatorhubio-catalog ready before test starts #2605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: akihikokuroda <[email protected]>
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
exdx
reviewed
Feb 2, 2022
| @@ -104,6 +104,9 @@ var _ = BeforeSuite(func() { | |||
| HaveLen(1), | |||
| ContainElement(Not(BeZero())), | |||
| )) | |||
| _, err := fetchCatalogSourceOnStatus(ctx.Ctx().OperatorClient(), "operatorhubio-catalog", operatorNamespace, catalogSourceRegistryPodSynced) | |||
There was a problem hiding this comment.
Thank you for your contribution -- I think this makes sense and is a safe addition.
/lgtm
timflannagan
approved these changes
Feb 2, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akihikokuroda, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: akihikokuroda [email protected]
Description of the change:
Make sure operatorhubio-catalog ready before e2e test starts
Motivation for the change:
Some tests are affected by the operatorhubio-catalog not ready status. This change make the e2e test more stable.
This line checks that all registries are OK before it resolves the operator.
operator-lifecycle-manager/pkg/controller/registry/resolver/resolver.go
Line 112 in 623572b
It's usually taking a little long time to get the operatorhubio registry ready and it sometimes causes test failures in the first a few tests.
Reviewer Checklist
/doc