-
Notifications
You must be signed in to change notification settings - Fork 562
Update CatalogSource Pod security context #2782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CatalogSource Pod security context #2782
Conversation
37cb6be
to
d666c11
Compare
d666c11
to
9ced412
Compare
b9ff32c
to
b826247
Compare
/hold waiting on discussion about approach |
65d8caf
to
6ae0109
Compare
92b55f2
to
a480d8b
Compare
/hold cancel |
7e1e2f1
to
1d99623
Compare
1d99623
to
c10972f
Compare
Signed-off-by: perdasilva <[email protected]>
Signed-off-by: perdasilva <[email protected]>
Signed-off-by: perdasilva <[email protected]>
c10972f
to
a32dbcb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The core changes to the catalog operator look good to me.
I'm not as sure about the FBC changes, but seeing as the e2e passes with these new images, it should be a safe change.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: exdx, perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…#2782)" This reverts commit 99b51e7. Signed-off-by: perdasilva <[email protected]>
* Revert "Unpack job security updates (#2805)" This reverts commit e568cde. Signed-off-by: perdasilva <[email protected]> * Revert "Update unpack job pod security (#2793)" This reverts commit eedad28. Signed-off-by: perdasilva <[email protected]> * Revert "Update CatalogSource Pod security context (#2782)" This reverts commit 99b51e7. Signed-off-by: perdasilva <[email protected]>
* Update ci artifact collection Signed-off-by: perdasilva <[email protected]> * Update e2e test images to use FBC Signed-off-by: perdasilva <[email protected]> * Update CatalogSource Pod security context Signed-off-by: perdasilva <[email protected]>
Signed-off-by: perdasilva [email protected]
Description of the change:
Updates the security context stanzas for the backing CatalogSource pod and container to be more explicit and limited
This PR also includes:
scripts/build_test_images.sh
to build and publish all e2e test catalogsget
anddescribe
calls to operate against all resources in the namespaceMotivation for the change:
https://bugzilla.redhat.com/show_bug.cgi?id=2088541
Reviewer Checklist
/doc
[FLAKE]
are truly flaky[FLAKE]
tag are no longer flaky