Skip to content

Update CatalogSource Pod security context #2782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

perdasilva
Copy link
Collaborator

@perdasilva perdasilva commented May 23, 2022

Signed-off-by: perdasilva [email protected]

Description of the change:
Updates the security context stanzas for the backing CatalogSource pod and container to be more explicit and limited

This PR also includes:

  • A migration of all e2e test catalogs to FBC (needed to get the tests to pass)
  • Moves any bundle image stored in a personal quay.io account to the olmtest account
  • Updates scripts/build_test_images.sh to build and publish all e2e test catalogs
  • An update to the ci artifact collection script:
    • simplifies the get and describe calls to operate against all resources in the namespace
    • collects the logs of any pod left in the namespace

Motivation for the change:
https://bugzilla.redhat.com/show_bug.cgi?id=2088541

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky
  • Tests that remove the [FLAKE] tag are no longer flaky

@openshift-ci openshift-ci bot requested review from ankitathomas and njhale May 23, 2022 10:44
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2022
@perdasilva perdasilva force-pushed the catsrc_security branch 4 times, most recently from 37cb6be to d666c11 Compare May 23, 2022 13:07
@perdasilva perdasilva closed this May 23, 2022
@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2022
@perdasilva perdasilva reopened this May 23, 2022
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2022
@perdasilva
Copy link
Collaborator Author

/hold waiting on discussion about approach

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2022
@perdasilva perdasilva force-pushed the catsrc_security branch 15 times, most recently from 65d8caf to 6ae0109 Compare May 30, 2022 08:45
@perdasilva perdasilva force-pushed the catsrc_security branch 6 times, most recently from 92b55f2 to a480d8b Compare June 2, 2022 13:07
@perdasilva
Copy link
Collaborator Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2022
@perdasilva perdasilva force-pushed the catsrc_security branch 4 times, most recently from 7e1e2f1 to 1d99623 Compare June 9, 2022 07:38
@perdasilva perdasilva mentioned this pull request Jun 9, 2022
11 tasks
Copy link
Member

@exdx exdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core changes to the catalog operator look good to me.

I'm not as sure about the FBC changes, but seeing as the e2e passes with these new images, it should be a safe change.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: exdx, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 99b51e7 into operator-framework:master Jun 9, 2022
perdasilva added a commit to perdasilva/operator-lifecycle-manager that referenced this pull request Jun 23, 2022
perdasilva added a commit to perdasilva/operator-lifecycle-manager that referenced this pull request Jun 23, 2022
perdasilva added a commit that referenced this pull request Jun 23, 2022
* Revert "Unpack job security updates (#2805)"

This reverts commit e568cde.

Signed-off-by: perdasilva <[email protected]>

* Revert "Update unpack job pod security (#2793)"

This reverts commit eedad28.

Signed-off-by: perdasilva <[email protected]>

* Revert "Update CatalogSource Pod security context (#2782)"

This reverts commit 99b51e7.

Signed-off-by: perdasilva <[email protected]>
perdasilva added a commit to perdasilva/operator-lifecycle-manager that referenced this pull request Jul 4, 2022
* Update ci artifact collection

Signed-off-by: perdasilva <[email protected]>

* Update e2e test images to use FBC

Signed-off-by: perdasilva <[email protected]>

* Update CatalogSource Pod security context

Signed-off-by: perdasilva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants