Skip to content

go.*,vendor: Bump the sigs.k8s.io/kind testing dependency #2887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

timflannagan
Copy link
Member

Signed-off-by: timflannagan [email protected]

Description of the change:
Bump the sigs.k8s.io/kind dependency to the v0.16.0 release which has support for Kubernetes 1.25.

Motivation for the change:
Maintenance.

Architectural changes:
N/A.

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci openshift-ci bot requested review from exdx and kevinrizza November 3, 2022 18:37
@openshift-ci
Copy link

openshift-ci bot commented Nov 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2022
@timflannagan
Copy link
Member Author

This is a quick follow-up to #2885 which bumps the Kubernetes client dependencies. The expectation here is that e2e will fail due to a check timing out now that we're deploying a Kubernetes cluster with a 1.25 server version.

@awgreene
Copy link
Member

awgreene commented Nov 3, 2022

I'm gonna look at updating the failing tests today. If a reasonable solution isn't found, it may make sense to extend this if statement to skip the test if not in the range of 1.21-1.24.

@awgreene
Copy link
Member

awgreene commented Nov 4, 2022

The expectation here is that e2e will fail due to a check timing out now that we're deploying a Kubernetes cluster with a 1.25 server version.

Follow up:

This messy commit:

  • Updates OLM to support the Deprecated kind if the binaries are built with the e2e go build tag.
  • Updates the failing test to introduce a Deprecated CRD to the cluster.
  • Updates the failing test to include a Deprecated CR in the installPlan step to trigger the event.
  • Removes the Skip based on k8s version.

@timflannagan timflannagan deleted the bump-kind branch November 7, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants