Skip to content

Specify exact verbs that OLM requires #3076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

awgreene
Copy link
Member

This will specifically allow OLM to avoid the "use" verb for SCCs that it wasn't configured to work with on OpenShift clusters.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2023
@dinhxuanvu
Copy link
Member

/retest

@awgreene
Copy link
Member Author

/hold
I'm considering this as an option over #3075 as it will be less disruptive.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 26, 2023
This will specifically allow OLM to avoid the "use" verb for SCCs that
it wasn't configured to work with on OpenShift clusters.

Signed-off-by: Alexander Greene <[email protected]>
@awgreene
Copy link
Member Author

/unhold
Discussed with the team and decided we're gonna go with this change in favor of #3075

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 26, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ncdc ncdc added this pull request to the merge queue Oct 26, 2023
@awgreene awgreene removed this pull request from the merge queue due to a manual request Oct 26, 2023
@kevinrizza
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2023
@ncdc ncdc added this pull request to the merge queue Oct 26, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 26, 2023
@awgreene awgreene added this pull request to the merge queue Oct 27, 2023
Merged via the queue into operator-framework:master with commit 1c419a3 Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants