Skip to content

catalog_e2e_test: add more logging #3089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2023
Merged

catalog_e2e_test: add more logging #3089

merged 1 commit into from
Nov 5, 2023

Conversation

stevekuznetsov
Copy link
Contributor

Description of the change:

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@stevekuznetsov stevekuznetsov force-pushed the skuznets/better-logging-e2e branch from 0a8abf4 to 72a1f4d Compare November 5, 2023 16:55
@stevekuznetsov
catalog_e2e_test: add more logging
7653065 
Signed-off-by: Steve Kuznetsov <[email protected]>
@stevekuznetsov stevekuznetsov force-pushed the skuznets/better-logging-e2e branch from 72a1f4d to 7653065 Compare November 5, 2023 16:55
@stevekuznetsov stevekuznetsov added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Nov 5, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stevekuznetsov
Copy link
Contributor Author

Tagging since it's just logging.

@stevekuznetsov stevekuznetsov mentioned this pull request Nov 5, 2023
Merged
@stevekuznetsov stevekuznetsov added this pull request to the merge queue Nov 5, 2023
Merged via the queue into operator-framework:master with commit 8f56d4a Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@dinhxuanvu dinhxuanvu Awaiting requested review from dinhxuanvu

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stevekuznetsov