Add Uninstall feature, add Makefile commands and organize docs #898

camilamacedo86 · 2019-06-09T07:10:46Z

Motivation

#896
#789

What

Add command make uninstall
Add make commands for manual/local installation
Organize information into the README. MD and doc/install.md
Add github files (PR/Issue templates)
Add CONTRIBUTION.MD doc
Replace the directory "Documentations" for doc in order to follow the project and org standards

Why

Adding missing steps to install
Make the info more easy to understand and to find
Follow the org standards
Asked for the required info when someone opens an issue
Give a better user experience

Steps to verify

Check the README
Check the install.md doc
Run make uninstall with a local installation

openshift-ci-robot · 2019-06-09T07:10:48Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: camilamacedo86
To complete the pull request process, please assign njhale
You can assign the PR to them by writing /assign @njhale in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2019-06-09T07:11:06Z

Hi @camilamacedo86. Thanks for your PR.

I'm waiting for a operator-framework or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

camilamacedo86 · 2019-06-10T08:59:20Z

c/c @njhale @alecmerdler @ecordell @jpeeler @fabiand @mhrivnak @wallyqs @mhrivnak @estroz @lilic @tkashem could you give me a hand here with the review/approval?

fabiand · 2019-06-14T07:39:56Z

This PR looks pretty good to me (a lot of eye on the details!), but I'm not an OLM maintainer.

ecordell

Thanks for the help! I think there are a couple of issues specifically around how we support OCP <4, but otherwise this is great!

ecordell · 2019-06-12T14:30:59Z

Makefile

+	- kubectl apply -f deploy/upstream/quickstart/crds.yaml
+	- kubectl apply -f deploy/upstream/quickstart/olm.yaml
+
+.PHONY: install-ocp


I'm not sure we should have this - OLM is already in OCP

In OCP 4 was released, however, how to test it locally? For Minishift it still required. I removed the 3.11 for the doc and a few changes in order to make it more clear. Please, let me know what do you think and if we can move forward in this way.

ecordell · 2019-06-12T14:31:27Z

Makefile

+install-ocp:
+	@echo Applying upstream quick start crd
+	- kubectl create -f deploy/ocp/manifests/latest/
+	- oc adm policy add-cluster-role-to-user cluster-admin system:serviceaccount:kube-system:default


Why is this clusterrolebinding needed?

To allow use it with Minishift.

README.md

ecordell · 2019-06-12T14:33:42Z

README.md

+spec:
+  channel: alpha
+  name: etcd
+  source: rh-operators


We should change these to point to the operatorhubio catalogs

I did a few changes. Please, check if it is ok for you now.

Makefile

ecordell · 2019-06-17T15:00:58Z

doc/install/install.md

+
+**NOTE** It is recommended for development pruposed and will use the source locally
+
+## Minishift


Minishift is deprecated, we don't want to steer users towards it

Deprecated for OLM? Where it was deprecated? How to test it locally with OCP?

I added the info that it is deprecated. I think we should keep it for a while

doc/install/install.md

Makefile

ecordell · 2019-06-19T17:10:20Z

/ok-to-test

camilamacedo86 · 2019-06-25T13:35:28Z

Hi @ecordell, could you please re-check it? Could we move forward here?

camilamacedo86 · 2019-07-10T12:11:52Z

Hi @ecordell,

All your comments were addressed. Please, could you check and let me know what still needs to be changed for we move forward here.

camilamacedo86 · 2019-07-19T15:42:03Z

Hi folks @njhale, @ecordell, @alecmerdler @jpeeler
Please, could we move forward here now or could you let me know what is missing?

camilamacedo86 · 2019-08-08T10:46:18Z

Hi folks @joelanford and @ecordell,

if you have time, could you please give me a hand for we are able to move forward here?
If you think that we should no move forward with nothing that was done here it is fine as well. Please, just let me know for we are able to close the PR in this situation.

…rstanble and add missing steps

…ers to operatorhub.io

camilamacedo86 · 2019-08-17T22:14:40Z

Closing it. It is open for a while and shows outdated currently.

openshift-ci-robot · 2019-08-17T23:12:18Z

@camilamacedo86: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-console-olm	`f7214b2`	link	`/test e2e-aws-console-olm`
ci/prow/e2e-aws-olm	`f7214b2`	link	`/test e2e-aws-olm`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

pierreozoux · 2019-10-15T12:26:11Z

Too bad this didn't land upstream ;) I also have stuck namespace..

dhrp · 2020-03-01T15:34:07Z

I can confirm this worked for me on Kubernetes, it got me out of the stuck namespace problem.

zzztimbo · 2020-04-10T22:07:52Z

Why wasn't this merged?

openshift-ci-robot · 2020-04-11T08:48:07Z

@camilamacedo86: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

camilamacedo86 · 2020-04-11T09:11:19Z

hi @ecordell,

Shows that it has been util for the users, so I rebased with the master and re-opened it.
See: #1438

openshift-ci-robot requested review from alecmerdler and njhale June 9, 2019 07:10

openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 9, 2019

openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 9, 2019

This was referenced Jun 10, 2019

[doc] - Installation and configuration process are not clear #896

Closed

Unable to uninstall OLM #789

Closed

fabiand mentioned this pull request Jun 14, 2019

Improve contribution guidelines kubevirt/kubevirt#2386

Closed

camilamacedo86 changed the title ~~Add Makefile commands and organize docs~~ Add Uninstall feature, add Makefile commands and organize docs Jun 17, 2019

ecordell reviewed Jun 17, 2019

View reviewed changes

openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 21, 2019

openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 4, 2019

camilamacedo86 added 4 commits August 17, 2019 23:05

feat(Makefile) : Organize install commands and add uninstall

83ad884

feat(github) : Add github files in order to follow org standard

562c352

doc(Readme/Install) : Organize information in order to make more unde…

904e268

…rstanble and add missing steps

feat(README) : Update info regards subscription and to address the us…

f7214b2

…ers to operatorhub.io

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 17, 2019

camilamacedo86 closed this Aug 17, 2019

camilamacedo86 reopened this Apr 11, 2020

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2020

camilamacedo86 closed this Apr 11, 2020

camilamacedo86 mentioned this pull request Apr 11, 2020

feat: add uninstall makefile target #1438

Merged


		NOTE It is recommended for development pruposed and will use the source locally

		## Minishift

Add Uninstall feature, add Makefile commands and organize docs #898

Add Uninstall feature, add Makefile commands and organize docs #898

Uh oh!

Conversation

camilamacedo86 commented Jun 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

What

Why

Steps to verify

Uh oh!

openshift-ci-robot commented Jun 9, 2019

Uh oh!

openshift-ci-robot commented Jun 9, 2019

Uh oh!

camilamacedo86 commented Jun 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabiand commented Jun 14, 2019

Uh oh!

ecordell left a comment

Choose a reason for hiding this comment

Uh oh!

ecordell Jun 12, 2019

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 Jun 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ecordell Jun 12, 2019

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 Jun 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ecordell Jun 12, 2019

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 Jun 18, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ecordell Jun 17, 2019

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 Jun 17, 2019

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 Jun 18, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ecordell commented Jun 19, 2019

Uh oh!

camilamacedo86 commented Jun 25, 2019

Uh oh!

camilamacedo86 commented Jul 10, 2019

Uh oh!

camilamacedo86 commented Jul 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camilamacedo86 commented Aug 8, 2019

Uh oh!

camilamacedo86 commented Aug 17, 2019

Uh oh!

openshift-ci-robot commented Aug 17, 2019

Uh oh!

pierreozoux commented Oct 15, 2019

Uh oh!

dhrp commented Mar 1, 2020

Uh oh!

zzztimbo commented Apr 10, 2020

Uh oh!

openshift-ci-robot commented Apr 11, 2020

Uh oh!

camilamacedo86 commented Jun 9, 2019 •

edited

Loading

camilamacedo86 commented Jun 10, 2019 •

edited

Loading

camilamacedo86 Jun 17, 2019 •

edited

Loading

camilamacedo86 Jun 17, 2019 •

edited

Loading

camilamacedo86 commented Jul 19, 2019 •

edited

Loading

camilamacedo86 commented Apr 11, 2020 •

edited

Loading