Skip to content

🌱 Add go-version check to avoid introducing a version that we cannot support yet #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

🌱 Add go-version check to avoid introducing a version that we cannot support yet #1657

merged 1 commit into from
Apr 28, 2025

Conversation

camilamacedo86
Copy link
Contributor

…

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@camilamacedo86 camilamacedo86 force-pushed the add-go-version-check branch 2 times, most recently from 93584b4 to 0bc5162 Compare April 28, 2025 17:54
@codecov Codecov
Copy link

codecov bot commented Apr 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.14%. Comparing base (16c6783) to head (cf45cd2).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1657      +/-   ##
==========================================
- Coverage   55.15%   55.14%   -0.02%     
==========================================
  Files         136      136              
  Lines       15911    15911              
==========================================
- Hits         8776     8774       -2     
- Misses       5982     5984       +2     
  Partials     1153     1153

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort
Copy link
Contributor

tmshort commented Apr 28, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2025
@bentito bentito changed the title 🌱 Add go-version check to avoid introduces an version that we cannot support yet 🌱 Add go-version check to avoid introducing a version that we cannot support yet Apr 28, 2025
grokspawn
grokspawn reviewed Apr 28, 2025
View reviewed changes
hack/tools/check-go-version.sh
@@ -0,0 +1,80 @@
#!/bin/bash

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is just a copy, but can you add a comment in here that the original source of this is o-f/op-con and to keep them in sync if there is a change?
We have the same kind of standard here.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2025
@grokspawn
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, grokspawn, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2025
@camilamacedo86 camilamacedo86 added this pull request to the merge queue Apr 28, 2025
Merged via the queue into operator-framework:master with commit af76233 Apr 28, 2025
11 of 12 checks passed
@github-actions github-actions bot mentioned this pull request Apr 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grokspawn grokspawn grokspawn left review comments

@tmshort tmshort tmshort approved these changes

@jmrodri jmrodri Awaiting requested review from jmrodri

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

Assignees

@tmshort tmshort

@grokspawn grokspawn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@camilamacedo86 @tmshort @grokspawn