Skip to content

chore: update o-f/api version to v0.12.0 #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tylerslaton
Copy link
Contributor

Description of the change:
Updating the operator framework API version to be v0.12.0.

Motivation for the change:
The latest version of the operator framework API, v0.12.0, is out and includes a breaking change by removing the "None" constraint and replacing it with "Not".

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci openshift-ci bot requested review from ankitathomas and njhale January 27, 2022 16:55
Copy link
Contributor

@ankitathomas ankitathomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2022
@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #911 (45cc6e8) into master (4e33928) will not change coverage.
The diff coverage is n/a.

❗ Current head 45cc6e8 differs from pull request most recent head 9fe5cac. Consider uploading reports for the commit 9fe5cac to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #911   +/-   ##
=======================================
  Coverage   52.18%   52.18%           
=======================================
  Files         103      103           
  Lines        9113     9113           
=======================================
  Hits         4756     4756           
  Misses       3451     3451           
  Partials      906      906           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e33928...9fe5cac. Read the comment docs.

@awgreene
Copy link
Member

/lgtm

Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitathomas, dinhxuanvu, tylerslaton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2022
@openshift-merge-robot openshift-merge-robot merged commit 00dbb12 into operator-framework:master Jan 27, 2022
@tylerslaton tylerslaton deleted the update-api-version branch January 27, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants