This repository was archived by the owner on Nov 18, 2020. It is now read-only.
memcached-operator: add memcached-operator example #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is based on the example in the operator-sdk user-guide and also includes example tests using the test framework.
|
@AlexNPavel could you add a readme on demonstrating the newly added testing framework and the testing command for this operator. we can do that in a separate PR if you like. |
hasbro17
reviewed
Aug 13, 2018
| "testing" | ||
| "time" | ||
|
|
||
| operator "github.com/operator-framework/operator-sdk/test/test-framework/pkg/apis/cache/v1alpha1" |
There was a problem hiding this comment.
This should be using the memcached CR type from within its own project:
cachev1alpha1 "github.com/operator-framework/operator-sdk-samples/memcached-operator/pkg/apis/cache/v1alpha1"
|
lgtm |
fanminshi
approved these changes
Aug 13, 2018
hasbro17
reviewed
Aug 13, 2018
memcached-operator/README.md
Outdated
| First, checkout and install the operator-sdk CLI: | ||
| ``` | ||
| $ cd $GOPATH/src/github.com/operator-framework/operator-sdk | ||
| $ git checkout master // currently, there are not releases that include the test framework, so use the master for now |
hasbro17
reviewed
Aug 14, 2018
| ### Initial Setup | ||
| Checkout this Memcached Operator repository | ||
| ``` | ||
| $ mkdir $GOPATH/src/github.com/operator-framework |
There was a problem hiding this comment.
This should already be present if they installed the sdk binary from github.com/operator-framework/operator-sdk in the previous step. So we can remove this.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the example in the operator-sdk user-guide and also
includes example tests using the test framework.