This repository was archived by the owner on Nov 18, 2020. It is now read-only.
Unit tests, revendor, logging updates #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XXL
hasbro17
reviewed
Nov 16, 2018
| dsize := *dep.Spec.Replicas | ||
| if dsize != replicas { | ||
| t.Errorf("dep size (%d) is not the expected size (%d)", dsize, replicas) | ||
| } |
There was a problem hiding this comment.
Was just about to comment on checking for the deployment before you updated it 😄
Can we also check if the reconciler successfully updates the CR's status.nodes with the pod names?
Of course we'll first have to manually create the 3 sample pods ourselves with the fake client.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a unit test example using
controller-runtime/pkg/client/fake. This is a first stab at unit testing usingfake. In the future we should scaffold a simple unit test for every controller created by the SDK. Docs incoming.Updated dependencies (wasn't building before) and import paths.
Updated logging statements in
memcached_controller.go.