feat(linter) : add goconst check and fix issues (#2236)

Author: camilamacedo86

hack/go-linter.sh

@@ -9,13 +9,13 @@ header_text "Running golangci-lint"
 golangci-lint run --disable-all \
     --deadline 5m \
     --enable=nakedret \
+    --enable=goconst \
 
 ##todo(camilamacedo86): The following checks requires fixes in the code
 # --enable=golint
 # --enable=gocyclo
 # --enable=goimports
 # --enable=lll
-# --enable=goconst
 # --enable=gosec
 # --enable=maligned
 # --enable=deadcode \

internal/scaffold/olm-catalog/csv_test.go

@@ -36,7 +36,14 @@ import (
 	appsv1 "k8s.io/api/apps/v1"
 )
 
-const testDataDir = "testdata"
+const (
+	testDataDir  = "testdata"
+	projectName  = "app-operator-dir"
+	operatorName = "app-operator"
+	oldCSVVer    = "0.1.0"
+	newCSVVer    = "0.2.0"
+	csvVer       = "0.1.0"
+)
 
 var testDeployDir = filepath.Join(testDataDir, scaffold.DeployDir)
 
@@ -47,9 +54,6 @@ func TestCSVNew(t *testing.T) {
 			return buf, nil
 		},
 	}
-	csvVer := "0.1.0"
-	projectName := "app-operator-dir"
-	operatorName := "app-operator"
 
 	sc := &CSV{CSVVersion: csvVer, pathPrefix: testDataDir, OperatorName: operatorName}
 	err := s.Execute(&input.Config{ProjectName: projectName}, sc)
@@ -71,9 +75,6 @@ func TestCSVNew(t *testing.T) {
 
 func TestCSVFromOld(t *testing.T) {
 	s := &scaffold.Scaffold{Fs: afero.NewMemMapFs()}
-	projectName := "app-operator-dir"
-	operatorName := "app-operator"
-	oldCSVVer, newCSVVer := "0.1.0", "0.2.0"
 
 	// Write all files in testdata/deploy to fs so manifests are present when
 	// writing a new CSV.
@@ -113,10 +114,6 @@ func TestCSVFromOld(t *testing.T) {
 }
 
 func TestUpdateVersion(t *testing.T) {
-	projectName := "app-operator-dir"
-	operatorName := "app-operator"
-
-	oldCSVVer, newCSVVer := "0.1.0", "0.2.0"
 	sc := &CSV{
 		Input:        input.Input{ProjectName: projectName},
 		CSVVersion:   newCSVVer,

internal/scorecard/plugins/olm_tests.go

@@ -274,6 +274,8 @@ func (t *CRDsHaveResourcesTest) Run(ctx context.Context) *schelpers.TestResult {
 }
 
 func getUsedResources(proxyPod *v1.Pod) ([]schema.GroupVersionKind, error) {
+	const api = "api"
+	const apis = "apis"
 	logs, err := getProxyLogs(proxyPod)
 	if err != nil {
 		return nil, err
@@ -322,38 +324,42 @@ func getUsedResources(proxyPod *v1.Pod) ([]schema.GroupVersionKind, error) {
 		splitURI = splitURI[1:]
 		switch len(splitURI) {
 		case 3:
-			if splitURI[0] == "api" {
+			if splitURI[0] == api {
 				resources[schema.GroupVersionKind{Version: splitURI[1], Kind: splitURI[2]}] = true
 				break
-			} else if splitURI[0] == "apis" {
+			}
+			if splitURI[0] == apis {
 				// this situation happens when the client enumerates the available resources of the server
 				// Example: "/apis/apps/v1?timeout=32s"
 				break
 			}
 			log.Warnf("Invalid URI: \"%s\"", uri)
 		case 4:
-			if splitURI[0] == "api" {
+			if splitURI[0] == api {
 				resources[schema.GroupVersionKind{Version: splitURI[1], Kind: splitURI[2]}] = true
 				break
-			} else if splitURI[0] == "apis" {
+			}
+			if splitURI[0] == apis {
 				resources[schema.GroupVersionKind{Group: splitURI[1], Version: splitURI[2], Kind: splitURI[3]}] = true
 				break
 			}
 			log.Warnf("Invalid URI: \"%s\"", uri)
 		case 5:
-			if splitURI[0] == "api" {
+			if splitURI[0] == api {
 				resources[schema.GroupVersionKind{Version: splitURI[1], Kind: splitURI[4]}] = true
 				break
-			} else if splitURI[0] == "apis" {
+			}
+			if splitURI[0] == apis {
 				resources[schema.GroupVersionKind{Group: splitURI[1], Version: splitURI[2], Kind: splitURI[3]}] = true
 				break
 			}
 			log.Warnf("Invalid URI: \"%s\"", uri)
 		case 6, 7:
-			if splitURI[0] == "api" {
+			if splitURI[0] == api {
 				resources[schema.GroupVersionKind{Version: splitURI[1], Kind: splitURI[4]}] = true
 				break
-			} else if splitURI[0] == "apis" {
+			}
+			if splitURI[0] == apis {
 				resources[schema.GroupVersionKind{Group: splitURI[1], Version: splitURI[2], Kind: splitURI[5]}] = true
 				break
 			}