Skip to content

feat(linter) : add goconst check and fix issues #2236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2019
Merged

feat(linter) : add goconst check and fix issues #2236

merged 1 commit into from
Nov 21, 2019

Conversation

camilamacedo86
Copy link
Contributor

Closes: #2223

@camilamacedo86 camilamacedo86 requested review from AlexNPavel and joelanford and removed request for AlexNPavel November 19, 2019 15:33
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 19, 2019
@camilamacedo86 camilamacedo86 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 19, 2019
estroz
estroz approved these changes Nov 19, 2019
View reviewed changes
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2019
@camilamacedo86 camilamacedo86 added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2019
joelanford
joelanford approved these changes Nov 21, 2019
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camilamacedo86 camilamacedo86 merged commit 07147b7 into operator-framework:master Nov 21, 2019
@camilamacedo86 camilamacedo86 deleted the fix-linter-goconst branch November 21, 2019 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford approved these changes

@estroz estroz estroz approved these changes

@theishshah theishshah Awaiting requested review from theishshah

@AlexNPavel AlexNPavel Awaiting requested review from AlexNPavel

@asmacdo asmacdo Awaiting requested review from asmacdo

@hasbro17 hasbro17 Awaiting requested review from hasbro17

@jmccormick2001 jmccormick2001 Awaiting requested review from jmccormick2001

@fabianvf fabianvf Awaiting requested review from fabianvf

Assignees

@estroz estroz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable goconst in the linter and fix issues
4 participants
@camilamacedo86 @joelanford @estroz @openshift-ci-robot