*: backport pin controller-runtime to v0.1.4 #828 to v0.2.x (#831)

* pkg/scaffold: Adjust gopkgtoml test to reflect change

* pkg/scaffold: Pin controller-runtime to exactly v0.1.4

When you specify a version without an operator, dep automatically uses
the ^ operator by default. That means it will take the major range.
That broke building of generated operators due to missing dependencies
in controller-runtime latest release.

* pkg/ansible/runner: logs the stdout and stderr from ansible-runner if the command exits non-zero

This is helpful in a case where ansible-runner itself is broken, such as when a
python library it depends on gets installed at an incompatible version (a
problem we've encountered multile times).

* test/ansible-operator/Dockerfile: lock idna to 2.7 (#813)

Author: hasbro17

pkg/ansible/runner/runner.go

@@ -245,9 +245,9 @@ func (r *runner) Run(ident string, u *unstructured.Unstructured, kubeconfig stri
 			dc = r.cmdFunc(ident, inputDir.Path)
 		}
 
-		err := dc.Run()
+		output, err := dc.CombinedOutput()
 		if err != nil {
-			logger.Error(err, "error from ansible-runner")
+			logger.Error(err, string(output))
 		} else {
 			logger.Info("ansible-runner exited successfully")
 		}

pkg/scaffold/gopkgtoml.go

@@ -80,7 +80,7 @@ required = [
 
 [[override]]
   name = "sigs.k8s.io/controller-runtime"
-  version = "v0.1.4"
+  version = "=v0.1.4"
 
 [[constraint]]
   name = "github.com/operator-framework/operator-sdk"

pkg/scaffold/gopkgtoml_test.go

@@ -72,7 +72,7 @@ required = [
 
 [[override]]
   name = "sigs.k8s.io/controller-runtime"
-  version = "v0.1.4"
+  version = "=v0.1.4"
 
 [[constraint]]
   name = "github.com/operator-framework/operator-sdk"

test/ansible-operator/Dockerfile

@@ -4,7 +4,7 @@ RUN yum remove -y ansible python-idna
 RUN pip uninstall ansible-runner -y
 
 RUN pip install --upgrade setuptools
-RUN pip install ansible ansible-runner openshift kubernetes ansible-runner-http
+RUN pip install ansible ansible-runner openshift kubernetes ansible-runner-http idna==2.7
 
 RUN mkdir -p /etc/ansible \
     && echo "localhost ansible_connection=local" > /etc/ansible/hosts \