Pin controller-runtime to v0.1.4 #828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
shawn-hurley
approved these changes
Dec 7, 2018
When you specify a version without an operator, dep automatically uses the ^ operator by default. That means it will take the major range. That broke building of generated operators due to missing dependencies in controller-runtime latest release.
lilic
force-pushed
the
lili/pin-controller-runtime
branch
from
36c1c8d to
205899c
Compare
lilic
changed the title
hasbro17
added a commit
that referenced
this pull request
Dec 10, 2018
* pkg/scaffold: Adjust gopkgtoml test to reflect change * pkg/scaffold: Pin controller-runtime to exactly v0.1.4 When you specify a version without an operator, dep automatically uses the ^ operator by default. That means it will take the major range. That broke building of generated operators due to missing dependencies in controller-runtime latest release. * pkg/ansible/runner: logs the stdout and stderr from ansible-runner if the command exits non-zero This is helpful in a case where ansible-runner itself is broken, such as when a python library it depends on gets installed at an incompatible version (a problem we've encountered multile times). * test/ansible-operator/Dockerfile: lock idna to 2.7 (#813)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
When you specify a version without an operator, dep automatically uses
the ^ operator by default. That means it will take the major range.
That broke building of generated operators due to missing dependencies
in controller-runtime latest release.
Motivation for the change:
operator-sdk master is currently broken. See #827 (comment)