pkg/ansible,pkg/helm: import client-go auth plugins

[joelanford]

Description of the change:
Imports all known Kubernetes client-go auth plugins in the Helm and Ansible operators

Motivation for the change:
For Go operators, we plan to add documentation about how users can add auth plugins to their cmd/manager/main.go file.

However, users of the Ansible and Helm operators don't have that option unless the convert their operator to a hybrid operator using operator-sdk migrate.

This closes #1178 and closes #1196

[AlexNPavel]

Why don't we add all the auth providers to the go cmd.go scaffold as well? We currently add the gcp auth provider by default: https://github.com/operator-framework/operator-sdk/blob/master/pkg/scaffold/cmd.go#L55

Is there a reason to include just the gcp provider by default in the go operators? Or should that be removed and instead be left to the users to handle for go based operators?

/cc @hasbro17

[joelanford]

@AlexNPavel Nice, I didn't realize we were doing that. I'll update the PR to include that.

Based on this comment, I'll also move the import closer to the top in a separate section, so we don't accidentally break things if we change imports later.

[hasbro17]

@AlexNPavel I think originally we thought it's an unnecessary dependency to include auth plugins that you won't use so we were initially intending for users to include them in their Go based operators as needed.

However since more and more users were running into issues on running the operator locally outside GKE we just added the gcp plugin by default.

To be more consistent we can either remove all plugins for Go operators and document clearly what users need to add. Or just add everything for them. I'm leaning towards the latter since it works out of the box.

And for Helm/Ansible operators we'll definitely need them by default since users can't add the imports themselves.

[joelanford]

I'm now debating where the imports for the Ansible and Helm operators should go.

In this PR, they're currently in both pkg/ansible/run.go and pkg/helm/run.go, but I'm now considering if it would be better to have the imports appear only in main functions in:

• the hybrid ansible operator main.go template
• the hybrid helm operator main.go template
• commands/operator-sdk/main.go to cover operator-sdk up local and operator-sdk run

go-lint warns that blank imports should only be in main functions (or have a comment to justify placement elsewhere). Also, putting them in the main functions of hybrid operators would line up more with the go operator and give developers of hybrid operators a hint that auth plugin imports can be tweaked.

Thoughts?

[hasbro17]

@joelanford That seems reasonable to me.
So long as we have up local and run covered by having the imports defined in cmd/operator-sdk/main.go

[joelanford]

@hasbro17 @AlexNPavel PTAL

[shawn-hurley]

LGTM

I don't like having to have all of these imported but don't see another way.

[AlexNPavel]

LGTM