Skip to content

internal: bring scorecard and scaffold up one level #2005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 23, 2019

Conversation

theishshah
Copy link
Member

Description of the change:

Bring scaffold and scorecard packages up one level to be in internal/

Motivation for the change:

Keeps internal as the parent pkg for all of our tools

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 2, 2019
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it really be done? Is not our intention to allow people to import the scorecard in their projects if they wish? Will be it possible if the code is in the internal dir? Also, will it NOT allow users to extending it to do as described here https://github.com/operator-framework/operator-sdk/blob/master/doc/test-framework/scorecard.md#extending-the-scorecard-with-plugins for example? 

c/c @joelanford @jmccormick2001 @estroz

@theishshah
Copy link
Member Author

/test e2e-aws-ansible

@camilamacedo86
Copy link
Contributor

Hi @theishshah,

It is missing a rebase with the master as well.

@theishshah
Copy link
Member Author

/test marker

@theishshah
Copy link
Member Author

/retest

@theishshah
Copy link
Member Author

/test e2e-aws-go

Copy link
Contributor

@jmccormick2001 jmccormick2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far. When you've got the merge conflicts fixed, ping me and I'll give it one last look to approve.

@joelanford
Copy link
Member

/test e2e-aws-helm
/test e2e-aws-ansible
/test e2e-aws-go
/test e2e-aws-subcommand

1 similar comment
@joelanford
Copy link
Member

/test e2e-aws-helm
/test e2e-aws-ansible
/test e2e-aws-go
/test e2e-aws-subcommand

@joelanford joelanford merged commit 424a61d into operator-framework:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants