-
Notifications
You must be signed in to change notification settings - Fork 1.8k
internal: bring scorecard and scaffold up one level #2005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal: bring scorecard and scaffold up one level #2005
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it really be done? Is not our intention to allow people to import the scorecard in their projects if they wish? Will be it possible if the code is in the internal dir? Also, will it NOT allow users to extending it to do as described here https://github.com/operator-framework/operator-sdk/blob/master/doc/test-framework/scorecard.md#extending-the-scorecard-with-plugins for example?
/test e2e-aws-ansible |
Hi @theishshah, It is missing a rebase with the master as well. |
/test marker |
/retest |
/test e2e-aws-go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far. When you've got the merge conflicts fixed, ping me and I'll give it one last look to approve.
/test e2e-aws-helm |
1 similar comment
/test e2e-aws-helm |
Description of the change:
Bring scaffold and scorecard packages up one level to be in internal/
Motivation for the change:
Keeps internal as the parent pkg for all of our tools