Makefile: Use hyphen instead of slash #2019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmrodri
requested review from
joelanford,
camilamacedo86,
hasbro17 and
shawn-hurley
and removed request for
shawn-hurley and
hasbro17
openshift-ci-robot
added
the
size/L
jmrodri
changed the title
jmrodri
force-pushed
the
use-hyphen-instead-of-slash
branch
from
aa0a1d7 to
280f338
Compare
|
This requires PR openshift/release#5327 |
There was a problem hiding this comment.
Hi @jmrodri,
The code changes show fine but it is not passing in the tests which shows that is not ok. Could you check it?
|
@camilamacedo86 so in order for this PR to pass it needs the prow config to know about the new |
Adding back the slashes to allow the CI to pass. We have a chicken and the egg problem. The CI for SDK doesn't know about the hyphens and the CI for the release PR doesn't know about the slashes.
jmrodri
force-pushed
the
use-hyphen-instead-of-slash
branch
from
1ed554a to
bb0d07a
Compare
joelanford
approved these changes
Oct 22, 2019
camilamacedo86
approved these changes
Oct 22, 2019
|
@joelanford updated the description |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to using
-instead of/for the targets. This came up in a comment of Issue #1950, kubebuilder uses-as well.