Skip to content

cherry-pick csv-gen bugfixes for #2015 #2017 #2021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hasbro17
Copy link
Contributor

@hasbro17 hasbro17 commented Oct 8, 2019

Description of the change:
Cherry pick of #2015 and #2017 bug fixes.

Motivation for the change:
Needed for the v0.10.1 release

@hasbro17 hasbro17 added kind/bug Categorizes issue or PR as related to a bug. backport This PR is a backport labels Oct 8, 2019
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 8, 2019
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camilamacedo86
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2019
@joelanford
Copy link
Member

@hasbro17 Looks like we need to cherry-pick #1888's commit (1cb0481) as well.

@camilamacedo86
Copy link
Contributor

Hi @hasbro17 and @joelanford,

@hasbro17 Looks like we need to cherry-pick #1888's commit (1cb0481) as well.

Done here: #2028

Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

hasbro17 and others added 2 commits October 9, 2019 14:04
… CRDs (operator-framework#2017)

* internal/pkg/scaffold/olm-catalog/csv_updaters.go: fix applying owned CRDs
* CHANGELOG.md: add line for operator-framework#2017

(cherry picked from commit 5bfe311)
@hasbro17 hasbro17 force-pushed the v0.10.x-backport-csv-gen-bug-fixes branch from 69ab9c3 to 253f615 Compare October 9, 2019 21:05
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2019
@hasbro17 hasbro17 merged commit 7052e8e into operator-framework:v0.10.x Oct 9, 2019
@hasbro17 hasbro17 deleted the v0.10.x-backport-csv-gen-bug-fixes branch October 9, 2019 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport This PR is a backport kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants