hack/tests/sanity-check.sh: fail on changed go.mod and go.sum #2098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
camilamacedo86
approved these changes
Oct 23, 2019
|
/test e2e-aws-subcommand |
1 similar comment
|
/test e2e-aws-subcommand |
|
/test e2e-aws-subcommand |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Revert sanity test changes from #1949
Motivation for the change:
In order to migrate to Go 1.13, we needed to temporarily ignore
go.modandgo.sumchanges that were caused by Go tooling during the sanity tests. Now that openshift/releases#5443 is merged, we can revert that temporary change so that we require that PRs correctly updatego.modandgo.sum.