doc: add note to described the possibility to use MultiNamespacedCach… #2281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
camilamacedo86
requested review from
joelanford,
jmrodri,
asmacdo,
jmccormick2001 and
shawn-hurley
camilamacedo86
added
the
kind/documentation
joelanford
requested changes
Dec 2, 2019
There was a problem hiding this comment.
/hold
Until kubernetes-sigs/controller-runtime#701 is merged.
openshift-ci-robot
added
do-not-merge/hold
camilamacedo86
removed
the
do-not-merge/hold
|
Hi @joelanford, removed the hold since it the kubernetes-sigs/controller-runtime#701 is merged. |
camilamacedo86
commented
Dec 3, 2019
hasbro17
reviewed
Dec 4, 2019
hasbro17
reviewed
Dec 4, 2019
joelanford
reviewed
Dec 5, 2019
| // Create a new Cmd to provide shared dependencies and start components | ||
| mgr, err := manager.New(cfg, manager.Options{ | ||
| NewCache: cache.MultiNamespacedCacheBuilder(namespaces), | ||
| MapperProvider: restmapper.NewDynamicRESTMapper, |
There was a problem hiding this comment.
Now that kubernetes-sigs/controller-runtime#554 is merged and we've updated to v0.4.0, we should remove our dynamic rest mapper implementation and any references to it.
That can be done in a follow up though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change:
Note: If this PR is fixing an issue make sure to add a note saying:
Closes #2008