pkg/util/tlsutil: add tls primitives functions #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanminshi
changed the title
fanminshi
force-pushed
the
tls_impl
branch
2 times, most recently
from
d92cf91 to
dacbcc5
Compare
|
fixed CI failure. |
|
I think you meant for the file name to be |
hasbro17
reviewed
Aug 14, 2018
pkg/tlsutil/primatives.go
Outdated
| ) | ||
|
|
||
| // NewPrivateKey returns randomly generated RSA private key. | ||
| func NewPrivateKey() (*rsa.PrivateKey, error) { |
There was a problem hiding this comment.
Do all of these helpers need to be exported? I can't see how they will end up being used by GenerateCert() but I assume it's going to be in the same package.
So we can keep these functions as lowercase and unexported.
They're not meant to be exposed to the user.
There was a problem hiding this comment.
yeah, you are right. they are not meant to be exported.
|
I kept the |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add tls primitives that generate the private key, the ca cert, and the signed cert for the private key.