Skip to content

⚠️ update Ansible requirements #5846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2022
Merged

⚠️ update Ansible requirements #5846

merged 2 commits into from
Jun 9, 2022

Conversation

camilamacedo86
Copy link
Contributor

Description
For Ansible-based language operators, upgrade

  • community.kubernetes from 1.2.1 to 2.0.1
  • kubernetes.core from 2.2.0 to 2.3.1
  • cloud.common from 2.2.0 to 2.2.1

@openshift-ci openshift-ci bot requested review from fabianvf and jmrodri June 9, 2022 12:28
@camilamacedo86 camilamacedo86 requested a review from asmacdo June 9, 2022 12:30
For Ansible-based language operators, upgrade
- `community.kubernetes` from `1.2.1` to `2.0.1`
- `kubernetes.core` from `2.2.0` to `2.3.1`
- `cloud.common` from `2.2.0` to `2.2.1`

Signed-off-by: Camila Macedo <[email protected]>
Copy link
Member

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nonblocking typo

@fabianvf
Copy link
Member

fabianvf commented Jun 9, 2022

Have we updated it in the scaffolding already?

@camilamacedo86
Copy link
Contributor Author

HI @fabianvf:

Have we updated it in the scaffolding already?

we update the requirements with make generate.
I do not see any other change that we should make in the scaffold.
Let me know if you see something

@camilamacedo86 camilamacedo86 merged commit 5257910 into operator-framework:master Jun 9, 2022
@camilamacedo86 camilamacedo86 deleted the ansible-kubernetes-core branch June 9, 2022 14:09
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

VenkatRamaraju pushed a commit to VenkatRamaraju/operator-sdk that referenced this pull request Jun 9, 2022
* ⚠️ update ansible requirements

For Ansible-based language operators, upgrade
- `community.kubernetes` from `1.2.1` to `2.0.1`
- `kubernetes.core` from `2.2.0` to `2.3.1`
- `cloud.common` from `2.2.0` to `2.2.1`

Signed-off-by: Camila Macedo <[email protected]>

* Apply suggestions from code review
@loganmc10
Copy link

cloud.common should be 2.1.0 and 2.1.1 (the notes say 2.2.0 and 2.2.1)

- name: cloud.common
version: "2.1.0"
version: "2.1.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camilamacedo86 I've created a PR to correct the version #5911

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants