pkg/ansible: Adding unit tests for the ansible operator reconcile loop #711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawn-hurley
added
refactoring
language/ansible
openshift-ci-robot
added
the
size/XL
shawn-hurley
force-pushed
the
feature/reconcile-unit-test
branch
4 times, most recently
from
939461d to
fd29031
Compare
|
@mhrivnak Can you take a look at the RunResult changes I made RunResult an interface so that the fake runner could easily create a fake.RunResult. This would allow the user of the fake, to fake |
mhrivnak
suggested changes
Nov 9, 2018
| m := map[string]interface{}{} | ||
| b, err := json.Marshal(status) | ||
| if err != nil { | ||
| return m |
There was a problem hiding this comment.
Is it ok to ignore the error here and just return an empty map?
There was a problem hiding this comment.
as discussed offline adding a log and mentioning that it eats the error on the doc.
| @@ -332,17 +332,27 @@ func (r *runner) makeParameters(u *unstructured.Unstructured) map[string]interfa | |||
| return parameters | |||
| } | |||
|
|
|||
| type RunResult interface { | |||
| Stdout() (string, error) | |||
There was a problem hiding this comment.
It would be good to move the comments from runResult.events and runResult.Stdout() to here so they'll show up in the documentation.
* Adding fakes for runner, and runner result. * Updating status object to be ouput as a map for deep copy functions.
shawn-hurley
force-pushed
the
feature/reconcile-unit-test
branch
from
fd29031 to
a68727c
Compare
djzager
approved these changes
Nov 19, 2018
mhrivnak
approved these changes
Nov 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Adding unit tests and fakes to test the reconciliation loop of the ansible operator.