pkg/scaffold: fixing main printVersion

[joelanford]

Description of the change:
Modifying the cmd/manager/main.go template so that the call to printVersion() occurs after the logger has been set.

Motivation for the change:
printVersion() does not currently print the version information.

If we're concerned that moving printVersion() beyond the very first call in main() will cause problems, we can also just use fmt.Printf() in printVersion() instead of using the logger.

[hasbro17]

we can also just use fmt.Printf() in printVersion() instead of using the logger.

Another issue is if someone gets rid of logf.SetLogger(logf.ZapLogger(false)) if they want to replace logr with their own logger, then they'd need to change the statements in printVerison() too or else the output would be silent (as it is right now).
That's not too hard to do but I guess fmt.Printf() would always print that info.

[joelanford]

Another issue is if someone gets rid of logf.SetLogger(logf.ZapLogger(false)) if they want to replace logr with their own logger

We could solve that by putting the log initialization back in main() and passing a logr.Logger to printVersion(). Then if a user got rid of the logr initialization, they would be forced to address that parameter.

I personally lean towards using the logr.Logger interface just to keep everything consistent.

The one argument I have for using something else is that it's possible for the logr initialization to fail, in which case we wouldn't be able to log the printVersion() stuff. Those logs are helpful for operator developers to troubleshoot issues, but none of those logs actually identify the operator binary itself (that would be something nice to add though), so I don't think its a problem in this case.

[estroz]

@hasbro17 as long as they have their log package aliased as log, printVersion() will work as intended with these changes. If they do not, the compiler will complain.

[estroz]

LGTM

[hasbro17]

Yeah agreed. I don't think it's unreasonable to assume that users will change the log alias if they decide to remove logr and its initialization entirely.

LGTM