Skip to content

Fix unit tests and conversion for ipv6 #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 15, 2025
Merged

Fix unit tests and conversion for ipv6 #416

merged 2 commits into from
May 15, 2025

Conversation

dranicu
Copy link
Member

@dranicu dranicu commented May 14, 2025

What this PR does / why we need it:

Fixing conversion and unit tests

@dranicu dranicu requested review from joekr and vladcristi May 14, 2025 15:08
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 14, 2025
@joekr
Copy link
Member

joekr commented May 15, 2025 •
edited
Loading

Unit tests

        github.com/oracle/cluster-api-provider-oci              coverage: 0.0% of statements
        github.com/oracle/cluster-api-provider-oci/cloud/metrics                coverage: 0.0% of statements
        github.com/oracle/cluster-api-provider-oci/cloud/config         coverage: 0.0% of statements
?       github.com/oracle/cluster-api-provider-oci/cloud/services/compute       [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement     [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/containerengine       [no test files]
        github.com/oracle/cluster-api-provider-oci/cloud/services/base          coverage: 0.0% of statements
        github.com/oracle/cluster-api-provider-oci/cloud/services/base/mock_base                coverage: 0.0% of statements
        github.com/oracle/cluster-api-provider-oci/cloud/services/containerengine/mock_containerengine          coverage: 0.0% of statements
        github.com/oracle/cluster-api-provider-oci/cloud/services/compute/mock_compute          coverage: 0.0% of statements
        github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement/mock_computemanagement              coverage: 0.0% of statements
?       github.com/oracle/cluster-api-provider-oci/cloud/services/identity      [no test files]
        github.com/oracle/cluster-api-provider-oci/cloud/scope/mocks            coverage: 0.0% of statements
?       github.com/oracle/cluster-api-provider-oci/cloud/services/loadbalancer  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer   [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/vcn   [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/workrequests  [no test files]
        github.com/oracle/cluster-api-provider-oci/cloud/services/loadbalancer/mock_lb          coverage: 0.0% of statements
        github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer/mock_nlb          coverage: 0.0% of statements
        github.com/oracle/cluster-api-provider-oci/cloud/services/vcn/mock_vcn          coverage: 0.0% of statements
        github.com/oracle/cluster-api-provider-oci/cloud/services/workrequests/mock_workrequests                coverage: 0.0% of statements
        github.com/oracle/cluster-api-provider-oci/cloud/services/identity/mock_identity                coverage: 0.0% of statements
?       github.com/oracle/cluster-api-provider-oci/version      [no test files]
        github.com/oracle/cluster-api-provider-oci/feature              coverage: 0.0% of statements
ok      github.com/oracle/cluster-api-provider-oci/api/v1beta1  47.998s coverage: 23.1% of statements
ok      github.com/oracle/cluster-api-provider-oci/api/v1beta2  0.032s  coverage: 14.5% of statements
ok      github.com/oracle/cluster-api-provider-oci/cloud/ociutil        0.004s  coverage: 15.9% of statements
ok      github.com/oracle/cluster-api-provider-oci/cloud/scope  19.933s coverage: 75.4% of statements
ok      github.com/oracle/cluster-api-provider-oci/cloud/util   0.325s  coverage: 45.1% of statements
ok      github.com/oracle/cluster-api-provider-oci/controllers  2.144s  coverage: 43.4% of statements
ok      github.com/oracle/cluster-api-provider-oci/exp/api/v1beta1      13.328s coverage: 15.3% of statements
ok      github.com/oracle/cluster-api-provider-oci/exp/api/v1beta2      0.043s  coverage: 4.8% of statements
ok      github.com/oracle/cluster-api-provider-oci/exp/controllers      0.496s  coverage: 51.8% of statements
go tool cover -func=coverage.out -o coverage.txt
go tool cover -html=coverage.out -o coverage.html

e2e tests

Ran 9 of 30 Specs in 3939.383 seconds
SUCCESS! -- 9 Passed | 0 Failed | 0 Pending | 21 Skipped

both tests look good

@vladcristi vladcristi merged commit 359bc8f into main May 15, 2025
2 checks passed
@vladcristi vladcristi deleted the fix_unit_tests_for_ipv6 branch May 15, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joekr joekr joekr approved these changes

@vladcristi vladcristi vladcristi approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dranicu @joekr @vladcristi