[JAVAVSCODE #196] Run Configuration section is unavailable in the Explorer panel for non-workspace opened Java files #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he Explorer panel for non-workspace opened Java files
Fixed runConfiguration.ts: `initializeRunConfiguration()` to search for java files in open editors when no workspace is open.
1. Checked for non-workspace opened files by testing the validity of `vscode.workspace.name` AND `vscode.workspace.workspaceFile`.
2. Searched for java extension file names in `vscode.workspace.textDocuments` when no workspace is open.
3. Fixed `RunConfigurationNode.setValue()` to invoke `WorkspaceConfiguration.update()` with `configurationTarget =` :
- `true`: when no workspace is open i.e. user global target;
- `null`: otherwise i.e. workspace target.
Fixes oracle#196
Signed-off-by: Siddharth Srinivasan <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed runConfiguration.ts:
initializeRunConfiguration()to search for java files in open editors when no workspace is open.vscode.workspace.nameANDvscode.workspace.workspaceFile.vscode.workspace.textDocumentswhen no workspace is open.RunConfigurationNode.setValue()to invokeWorkspaceConfiguration.update()withconfigurationTarget =true: when no workspace is open i.e. user global target;null: otherwise i.e. workspace target.Fixes #196