[JAVAVSCODE #199] Quick Fix actions are unable to edit runConfig options in global settings for non-workspace opened Java files #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g options in global settings for non-workspace opened Java files
Fixed extension.ts `UpdateConfigurationRequest` handler to update the global `WorkspaceConfiguration` for non-workspace opened files.
1. Checked for non-workspace opened files by testing if `vscode.workspace.workspaceFile` is undefined/null.
2. Invoked `WorkspaceConfiguration.update()` with `configurationTarget = `:
- `true`: for non-workspace files;
- `null`: otherwise.
3. Added a try-catch to log errors in update and prevent downstream failures.
4. Avoided an unnecessary `await` and used the `Thenable` chain of `update()`.
Fixes oracle#199
Signed-off-by: Siddharth Srinivasan <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
…g options in global settings for non-workspace opened Java files Removed unnecessary if check for vscode.workspace, in the previous fix commit; since it is a VS Code API namespace. Signed-off-by: Siddharth Srinivasan <[email protected]>
sid-srini
deleted the
vsc199-update-global-settings-non-workspace-runConfig
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed extension.ts
UpdateConfigurationRequesthandler to update the globalWorkspaceConfigurationfor non-workspace opened files.vscode.workspace.workspaceFileis undefined/null.WorkspaceConfiguration.update()withconfigurationTarget =true: for non-workspace files;null: otherwise.awaitand used theThenablechain ofupdate().Closes #199