Skip to content

Fix formatting issue of xml files #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

Achal1607
Copy link
Member

Adding modules org.netbeans.modules.editor.deprecated.pre65formatting and org.netbeans.modules.editor.structure back into the extension.

closes #185

@Achal1607 Achal1607 requested a review from sid-srini August 5, 2024 12:51
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 5, 2024
Copy link
Member

@sid-srini sid-srini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems ok for now.

Side note: The deprecated class org.netbeans.modules.editor.structure.formatting.TagBasedFormatter does use the module org.netbeans.modules.editor.deprecated.pre65formatting. So including it seems unavoidable at this stage till it is removed from NB.

@Achal1607 Achal1607 merged commit e3b3877 into oracle:main Aug 7, 2024
3 checks passed
@sid-srini sid-srini added this to the JVSC 22.1.2 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clicking on XML file generates an exception
2 participants