Skip to content

NB-23 patches compatible with Java source version 1.8 #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

Achal1607
Copy link
Member

Patches that were backported from NB-23 in PRs: #220 and #227 made compatible to work with Java source version 1.8

@Achal1607 Achal1607 requested a review from sid-srini August 9, 2024 09:50
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 9, 2024
lahodaj
lahodaj previously approved these changes Aug 12, 2024
Copy link
Member

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Copy link
Member

@sid-srini sid-srini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@sid-srini sid-srini merged commit 34c8629 into oracle:main Aug 13, 2024
3 checks passed
@sid-srini sid-srini added this to the JVSC 22.1.2 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants