Skip to content

Refactored JDK Downloader #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2024
Merged

Refactored JDK Downloader #248

merged 1 commit into from
Sep 10, 2024

Conversation

Achal1607
Copy link
Member

Improvements after refactoring JDK downloader:

  • Transitioned from a functional to a class-based approach for better code organization and maintainability.
  • Progress bar is also shown while downloading any JDK
  • Improved error handling mechanisms
  • Added comprehensive logging throughout the code to aid in debugging and increase traceability
  • Replaced axios with node native library

@Achal1607 Achal1607 requested a review from sid-srini August 28, 2024 08:56
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 28, 2024
@Achal1607 Achal1607 changed the base branch from main to 23.0.0 August 28, 2024 15:33
naren2605
naren2605 reviewed Aug 29, 2024
View reviewed changes
naren2605
naren2605 reviewed Aug 29, 2024
View reviewed changes
naren2605
naren2605 reviewed Aug 29, 2024
View reviewed changes
naren2605
naren2605 reviewed Aug 29, 2024
View reviewed changes
@Achal1607 Achal1607 requested a review from naren2605 August 30, 2024 06:31
@Achal1607 Achal1607 mentioned this pull request Aug 31, 2024
Closed
sid-srini
sid-srini requested changes Sep 4, 2024
View reviewed changes
Copy link
Member

@sid-srini sid-srini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more reliable JDK download experience with progress notifications is a welcome addition. Thank you very much @Achal1607. And also for refactoring and cleaning up the code into view and control parts.

Couple of minor requests are mentioned inline.

@Achal1607 Achal1607 force-pushed the reworked-jdk-downloader branch 2 times, most recently from c420806 to be815f2 Compare September 4, 2024 19:53
@Achal1607
Copy link
Member Author

@sid-srini thank you for reviewing the PR. I have addressed the comments

@Achal1607 Achal1607 force-pushed the reworked-jdk-downloader branch from dc7ba8f to b05d4d0 Compare September 9, 2024 06:58
naren2605
naren2605 reviewed Sep 9, 2024
View reviewed changes
naren2605
naren2605 reviewed Sep 9, 2024
View reviewed changes
naren2605
naren2605 reviewed Sep 9, 2024
View reviewed changes
@naren2605
Copy link
Member

naren2605 commented Sep 9, 2024 •
edited
Loading

LGTM, thank you @Achal1607

@Achal1607 Achal1607 force-pushed the reworked-jdk-downloader branch from 69c1197 to c4a49dd Compare September 10, 2024 05:00
@sid-srini sid-srini merged commit 1e861b0 into oracle:23.0.0 Sep 10, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naren2605 naren2605 naren2605 approved these changes

@sid-srini sid-srini sid-srini approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Achal1607 @naren2605 @sid-srini