Restrict parent directory traversal for finding the associated project #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
sid-srini
force-pushed
the
restrict_parent_directory_traversal_for_project
branch
from
ced505f to
1465694
Compare
|
When written like this, I see a problem if the user will have a folder in the workspace that is not under the user's home. For example, having a Maven project
|
Understood.
|
sid-srini
force-pushed
the
restrict_parent_directory_traversal_for_project
branch
2 times, most recently
from
fec8965 to
992b22d
Compare
Achal1607
reviewed
Sep 3, 2024
**Changes**
1. Added a launch-time JVM property for the netbeans LSP server
"project.limitScanRoot", with its value set to the user's home
directory path and the workspace folders, if any.
- This is obtained using Node's `os.homedir()` function in *nbcode.ts*
- Multiple paths are delimited by the OS-specific separator.
2. Added a configuration property "jdk.advanced.disable.projectSearchLimit"
which can be used to turn off this new behaviour.
**Reasons**
- NetBeans supports searching for the build project information in the
ancestor directories of the file or folder opened in a workspace.
- Thus, NetBeans `org.netbeans.modules.projectapi.SimpleFileOwnerQueryImplementation`
supports a JVM launch property (i.e. System property) called **project.limitScanRoot**.
- This prevents searching for the build project information when the
opened file or folder is outside this specified path.
Signed-off-by: Siddharth Srinivasan <[email protected]>
sid-srini
force-pushed
the
restrict_parent_directory_traversal_for_project
branch
from
992b22d to
90d6615
Compare
sid-srini
deleted the
restrict_parent_directory_traversal_for_project
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
os.homedir()function in nbcode.tsReasons
org.netbeans.modules.projectapi.SimpleFileOwnerQueryImplementationsupports a JVM launch property (i.e. System property) called project.limitScanRoot.