Skip to content

Fix build script and tests for windows platform #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

Achal1607
Copy link
Member

@Achal1607 Achal1607 requested a review from sid-srini September 2, 2024 09:38
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 2, 2024
Copy link
Member

@sid-srini sid-srini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Achal1607 for figuring out this tenuous problem.

I would prefer to wait and check if some of the ongoing PRs will help resolve the scan root problem without removing that argument.

@Achal1607
Copy link
Member Author

Thanks @Achal1607 for figuring out this tenuous problem.

I would prefer to wait and check if some of the ongoing PRs will help resolve the scan root problem without removing that argument.

Okay will wait for that changes, thank you for reviewing

@Achal1607 Achal1607 changed the base branch from testing to 23.0.0 September 6, 2024 20:56
@Achal1607 Achal1607 changed the base branch from 23.0.0 to testing September 6, 2024 20:57
@Achal1607 Achal1607 requested a review from sid-srini September 10, 2024 07:38
Copy link
Member

@sid-srini sid-srini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@Achal1607 Achal1607 merged commit 256995e into oracle:testing Sep 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants