Skip to content

Added tests for localisation #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

shivam71
Copy link
Member

Automated tests for testing frontend localisation.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 30, 2024
@Achal1607 Achal1607 added the do not merge Don't merge PR label Oct 1, 2024
@shivam71 shivam71 changed the base branch from testing to main October 1, 2024 06:25
@shivam71 shivam71 force-pushed the Localisation_Tests branch from bbcb8db to b770add Compare October 1, 2024 07:02
@shivam71
Copy link
Member Author

@sid-srini Please review again , post that I will squash and merge after the refactored extension code gets merged . I will need to make some more changes then .

@Achal1607 Achal1607 removed the do not merge Don't merge PR label Oct 15, 2024
sid-srini
sid-srini previously approved these changes Oct 25, 2024
Copy link
Member

@sid-srini sid-srini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. Thanks 👍

@sid-srini sid-srini added this to the JVSC 23.0.1 milestone Oct 25, 2024
@shivam71 shivam71 force-pushed the Localisation_Tests branch 2 times, most recently from 1c4e3ca to 3025bf1 Compare October 28, 2024 08:05
@Achal1607 Achal1607 requested a review from sid-srini October 28, 2024 08:13
Copy link
Member

@sid-srini sid-srini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shivam71. 👍 LGTM

Copy link
Member

@Achal1607 Achal1607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Achal1607 Achal1607 merged commit 053ddf6 into oracle:main Oct 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants