Skip to content

Relabeled the command "New From Template" to "New File" #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sid-srini
Copy link
Member

In order to improve readability and clarity, changed the label for the command to create a new class/test/interface/exception etc.

  • "New from Template" --> "New File"

Also updated the label references in READMEs, messages and translations.

In order to improve readability and clarity, changed the label for the
command to create a new class/test/interface/exception etc.
"New from Template" --> "New File"

Also updated the label references in READMEs, messages and translations.

Signed-off-by: Siddharth Srinivasan <[email protected]>
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 24, 2024
Copy link
Member

@Achal1607 Achal1607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@sid-srini sid-srini merged commit aaed076 into oracle:main Oct 25, 2024
2 checks passed
@sid-srini sid-srini deleted the relabel-New_From_Template-to-New_File branch October 25, 2024 05:42
@sid-srini sid-srini added this to the JVSC 23.0.1 milestone Oct 25, 2024
sid-srini added a commit to sid-srini/javavscode that referenced this pull request Nov 6, 2024
In order to improve readability and clarity, changed the label for the
command to create a new class/test/interface/exception etc.
"New from Template" --> "New File from Template"

Also updated the label references in READMEs, messages and translations.

This also avoids the command "New File" getting repeated twice in the
Project explorer panel if it is simplified further as done in PR oracle#302.

Signed-off-by: Siddharth Srinivasan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants