Skip to content

Changes to maintain a single README file. #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2024
Merged

Changes to maintain a single README file. #339

merged 1 commit into from
Dec 10, 2024

Conversation

shivam71
Copy link
Member

@shivam71 shivam71 commented Dec 9, 2024 •
edited
Loading

  • Removed the README inside the vscode folder
  • Added ant tasks for creating the README for packaging
  • Excluded images folder from the vsix as it was not being used

To test the README that will be created and uploaded on marketplace follow the steps :-

  1. Build the vscode ext with ant build-vscode-ext.
  2. Unzip the vsix .(change extension to .zip and then unzip.)
  3. Open the README in the vsix and preview the markdown as well as check the relative urls in the markdown itself.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 9, 2024
Achal1607
Achal1607 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@Achal1607 Achal1607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Achal1607 Achal1607 added this to the JVSC 23.1.0 milestone Dec 9, 2024
naren2605
naren2605 reviewed Dec 9, 2024
View reviewed changes
@sid-srini sid-srini merged commit b86b93a into oracle:main Dec 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naren2605 naren2605 naren2605 left review comments

@Achal1607 Achal1607 Achal1607 approved these changes

@Dexxxto Dexxxto Dexxxto approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
JVSC 23.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@shivam71 @naren2605 @Achal1607 @Dexxxto @sid-srini