Updated vsix building in order to pass vsixsigntool validation after modified codesigning flow #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is valid. 1. Added .sh extension to: ant, antRun, mvnDebug, mvnjyp. 2. Added .txt extension to: NOTICE, LICENSE, project-marker-jdk. 3. Ignore nb clusters .lastModified files and node_modules .npmignore from vsix packaging. Signed-off-by: Siddharth Srinivasan <[email protected]>
from the file extension string that is populated in [Content-Types.xml] for the different files in the extension. Signed-off-by: Siddharth Srinivasan <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
lahodaj
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
vsixsigntoolhas certain pre-requisites for its verification to pass. These are no longer done in the code-signing flow, requiring them to be performed prior to the creation of the vsix.It seems that the VS Code Marketplace publishing uses a different validation flow for signed vsix, since the unsigned vsix created by the @vscode/vsce node tool doesn't adhere to these restrictions.
For example:
[Content_Types].xmlmust contain file-extension strings without a'.'prefix in a signed vsix-extension.