Automate dropdown options of OracleJDK version in JDK downloader #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
sid-srini
requested changes
Feb 18, 2025
There was a problem hiding this comment.
Thanks @Achal1607 . This will significantly improve jdk access. One small suggestion would be to maintain the old jdk versions list as a fallback, in case the remote fetch fails due to some external cause or API change.
sid-srini
reviewed
Feb 20, 2025
added fallback versions removed redundant unit tests updated JDK fallback versions
Achal1607
force-pushed
the
automate-oracle-jdk-selection
branch
from
e888244 to
75ac5ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automate options available in OracleJDK download options in JDK Downloader.
Also, removed a test which was redundant. It was directly testing the stub instead of the original method due to which race condition is happening and it is failing.