Skip to content

Fixed label and id issue in JDK downloader #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2025
Merged

Fixed label and id issue in JDK downloader #379

merged 1 commit into from
Feb 25, 2025

Conversation

Achal1607
Copy link
Member

  • Label constant was being used as id in JDK downloader which can be a issue if labels are localised.
  • So, separated out labels and Ids so that localisation doesn't affect the Id creation.

@Achal1607 Achal1607 requested a review from sid-srini February 25, 2025 05:29
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 25, 2025
sid-srini
sid-srini approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@sid-srini sid-srini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Achal1607. LGTM 👍

@Achal1607 Achal1607 merged commit af82913 into oracle:telemetry Feb 25, 2025
3 checks passed
@Achal1607 Achal1607 mentioned this pull request Mar 17, 2025
Merged
@Achal1607 Achal1607 added this to the JVSC 24.1.0 milestone Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sid-srini sid-srini sid-srini approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
JVSC 24.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Achal1607 @sid-srini